Bug #208

spec for bug #1322

Added by coderrr x 194 days ago. Updated 191 days ago.

Status :Resolved Start :02/19/2010
Priority :Normal Due date :
Assigned to :- % Done :

0%
Category :-
Target version :-

Description

spec for bug #1322

0001-bug-spec-for-1322.patch (1.1 KB) coderrr x, 02/19/2010 12:43 PM

0001-bug-spec-for-1322.patch (961 Bytes) coderrr x, 02/19/2010 12:16 PM

History

02/19/2010 12:26 PM - Brian Ford

Hi,

Some issues with this patch:

  • Why is the spec defining the method on Object? Does this bug only affect a method defined on Object? If not, use a fixture class or a mock.
  • The bug_method_1322 is unnecessarily ugly and makes the spec harder to read. The bug # is already in the ruby_bug guard.
  • Why is the method called with (nil)?
  • The spec description string needs to read naturally, "it lambda" is not grammatical.

Cheers,
Brian

02/19/2010 12:43 PM - coderrr x

this better?

02/22/2010 10:22 AM - Brian Ford

  • Status changed from New to Resolved

Thanks for the spec. Committed in 5c92efd. Please see cleanups in 8ab09fc.

Also available in: Atom PDF