Feature #73

Specs for Ping Module in the Standard Library

Added by Brad Gignac 48 days ago. Updated 48 days ago.

Status :Resolved Start :11/18/2008
Priority :Normal Due date :
Assigned to :- % Done :

100%
Category :-
Target version :-

Description

I didn't see any test for the Ping Module, so I implemented them. This is my first submitted patch, so I apologize if there are any problems with these patches. Please let me know how I can improve in the future.

0001-Added-test-files-for-Ping-pingecho.patch (1.6 KB) Brad Gignac, 11/18/2008 12:53 PM

0002-Added-newline-to-the-end-of-the-file-to-get-rid-of-D.patch (674 Bytes) Brad Gignac, 11/18/2008 12:53 PM

0003-Changed-fixes-to-Ping-pingecho-to-fit-style-guide.patch (1.5 KB) Brad Gignac, 11/18/2008 12:53 PM

History

11/18/2008 03:15 PM - Brian Ford

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Added in cc3f1a26. I squashed the commits into one since two of them were just fixups. I tend to use git commit --amend for this when working on something so that I can commit regularly but not have a lot of scratch work commits when I push. Also. git rebase --interactive is a big help.

The specs look good. Thanks for reviewing the style guide. I did move the require 'ping' line after the require for the spec helper. This is the standard way so that spec_helper.rb can do any necessary setup.

Let me know your github username and I'll add you to the project.

Thanks for helping!

Also available in: Atom PDF