rubyspec

ARGF specs attached

Laurent,

Awesome. That is a lot of work! Most of it looks great. Here are a couple suggestions:

• Use ARGV.close unless ARGV.closed? because the 'rescue nil' has obscured bugs in the past
• You could create a helper in ARGFSpec for this sort of thing: File.read(File.dirname(__FILE__) + '/fixtures/file1.txt') or we could add a helper to mspec like fixture("file1.txt") that would return File.dirname(__FILE__) + "/fixtures/#{name}" and you can File.read, File.open, etc.

Here are some issues I see on OS X intel when running all the specs with 'mspec -tr .'

2)
IO#fileno returns the numeric file descriptor of the given IO object FAILED
Expected 3
 to equal 1

./1.8/core/io/fileno_spec.rb:6
./1.8/core/io/fileno_spec.rb:2:in `all?'
./1.8/core/io/fileno_spec.rb:4

3)
IO #print writes $_.to_s followed by $\ (if any) to the stream if no arguments given FAILED
Expected (STDOUT): "I know what you did last line!->" 
         but got: "" 
Backtrace
./1.8/core/io/print_spec.rb:23
./1.8/core/io/print_spec.rb:2:in `all?'
./1.8/core/io/print_spec.rb:4

4)
IO#puts writes just a newline when given just a newline FAILED
Expected (STDOUT): "\n" 
          but got: "" 
Backtrace
./1.8/core/io/puts_spec.rb:19
./1.8/core/io/puts_spec.rb:8

5)
IO#to_i return the numeric file descriptor of the given IO object FAILED
Expected 3
 to equal 1

./1.8/core/io/to_i_spec.rb:6
./1.8/core/io/to_i_spec.rb:2:in `all?'
./1.8/core/io/to_i_spec.rb:4

6)
Kernel#p is not affected by setting $\, $/ or $, FAILED
Expected (STDOUT): "Next time, Gadget, NEXT TIME!\n" 
         but got: "" 
Backtrace
./1.8/core/kernel/p_spec.rb:53
./1.8/core/kernel/p_spec.rb:4

Contrary to what I said yesterday i observed the same side effect on IO specs and fiwed the problems. It turned out that testing ARGF with in place editing had side effect on the internal Ruby IOs which caused the errors.

The solution was to run the tests dealing with in place editing in separate Ruby process to avoid any side effect. It works flawlessly on my side now. Can you test on Mac OS X?

Thanks!

I'm seeing a lot of these specs already in Rubyspec, can we close this as resolved?

The vast majority have been added. We'll surely refine some, but I agree, we can close this ticket.